GUACAMOLE-1875: Check return values of WebP API functions. #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @vrabaud. Please open a Jira ticket (you may need to request an account, if you don't already have one) for this and tag the Jira ticket number (GUACAMOLE-XXXX:) in both the PR and the commit messages. |
|
It says it will take days to create an account. |
vrabaud
force-pushed
the
patch-1
branch
2 times, most recently
from
7a1f1f5
to
570d92d
Compare
|
I rebased as the CI error was unrelated. Maybe it got fixed at HEAD. |
Yes, there was an issue causing build failures that is now fixed. Also, I see that you got the account and opened the ticket - please update Pull Request with GUACAMOLE-XXXX: prefix, along with commit requests. Thanks!! |
vrabaud
changed the title
Those will be made nodiscard at some point anyway.
|
Done |
necouchman
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those will be made nodiscard at some point anyway.
Issue GUACAMOLE-1875